allow promtail installation via package #41
Conversation
| Optional[Sensitive[String[1]]] $password_file_content = undef, | ||
| Stdlib::HTTPUrl $source_url = 'https://github.com/grafana/loki/releases/download', | ||
| Enum['package', 'archive'] $install_method = 'archive', | ||
| Enum['installed', 'absent'] $package_ensure = 'installed', |
There was a problem hiding this comment.
Please also allow latest or simply any valid string which would allow pinning versions.
| service { 'promtail': | ||
| ensure => $promtail::service_ensure, | ||
| enable => $promtail::service_enable, | ||
| require => Systemd::Unit_file['promtail.service'], |
There was a problem hiding this comment.
Why is this line being removed?
There was a problem hiding this comment.
If you use a package the systemd unit file would be managed by the package and not as a resource in Puppet.
See block #9-13 in this file
There was a problem hiding this comment.
It seems to me that it would make sense then to add a before param to the unit file then...
|
@bastelfreak just checking in on the couple of comments above |
|
|
| if $promtail::install_method == 'archive' { | ||
| systemd::unit_file { 'promtail.service': | ||
| source => 'puppet:///modules/promtail/promtail.service', | ||
| notify => Service['promtail'], | ||
| } | ||
| } |
There was a problem hiding this comment.
| if $promtail::install_method == 'archive' { | |
| systemd::unit_file { 'promtail.service': | |
| source => 'puppet:///modules/promtail/promtail.service', | |
| notify => Service['promtail'], | |
| } | |
| } | |
| if $promtail::install_method == 'archive' { | |
| systemd::unit_file { 'promtail.service': | |
| source => 'puppet:///modules/promtail/promtail.service', | |
| before => Service['promtail'], | |
| notify => Service['promtail'], | |
| } | |
| } |
No description provided.